Move creating transaction request parameters to Transaction module#17
Open
BogdanDidenko wants to merge 1 commit intonebulasio:masterfrom
Open
Move creating transaction request parameters to Transaction module#17BogdanDidenko wants to merge 1 commit intonebulasio:masterfrom
BogdanDidenko wants to merge 1 commit intonebulasio:masterfrom
Conversation
Contributor
|
@BogdanDidenko Thanks the PR, but API and admin need not require the transaction module, because we have neb-light and neb package library, they need not depend on lots of cryptos libraries. |
Contributor
Author
|
It's bad solution because in all places you have the request structure And If you change some commands or parameter type on server you should change it in all places. And this approach can have potential problems with backward compatibility and cetera |
Contributor
|
Yeah, We may need a util or parameter js file to handle the parameters check. |
Contributor
Author
|
Maybe some validation module with strategies for different types of parameters. |
Contributor
|
Later We can add the validation module. |
Contributor
Author
|
Yes. It's not top-priority task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed code duplicates. Encapsulate creating transaction parameters in Transaction module